ngsg commented on code in PR #6128:
URL: https://github.com/apache/hive/pull/6128#discussion_r2432729725
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupingSetOptimizer.java:
##########
@@ -182,6 +182,12 @@ private boolean isParentOpFeasible(Operator<?> parentOp) {
}
private String selectPartitionColumn(GroupByOperator gby, Operator<?>
parentOp) {
+ if (parentOp.getColumnExprMap() == null) {
+ LOG.debug("Skip grouping-set optimization as the parent operator {}
does not define a column expression mapping",
+ parentOp);
Review Comment:
Could we adjust the indentation to 4 spaces to match the rest of the code?
```suggestion
LOG.debug("Skip grouping-set optimization as the parent operator {}
does not define a column expression mapping",
parentOp);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
