Indhumathi27 commented on code in PR #6128:
URL: https://github.com/apache/hive/pull/6128#discussion_r2431453863
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupingSetOptimizer.java:
##########
@@ -227,7 +227,8 @@ private String selectPartitionColumn(GroupByOperator gby,
Operator<?> parentOp)
String partitionCol = null;
for (ColStatistics col: columnStatistics) {
String colName = col.getColumnName();
- if (parentOp.getColumnExprMap().containsKey(colName) &&
candidates.contains(colName)) {
+ if (null != parentOp.getColumnExprMap() &&
parentOp.getColumnExprMap().containsKey(colName) &&
+ candidates.contains(colName)) {
Review Comment:
I agree we can handle this in isParentOpFeasible method for UNION case. And
also have this null check, as it avoid NPE in unknown cases. @okumin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
