okumin commented on PR #6115:
URL: https://github.com/apache/hive/pull/6115#issuecomment-3383669021
@InvisibleProgrammer
It is challenging to specify a single script because the header variations
of the original code differ. As explained, I validated the final deliverable
using Checkstyle. If we want more substantial evidence, I can split this PR
into some PRs per a set of patterns.
### How was this patch tested?
I put the following configuration on `checkstyle/checkstyle.xml`,
`standalone-metastore/checkstyle/checkstyle.xml`, and
``storage-api/checkstyle/checkstyle.xml. After that, I ran `mvn
checkstyle:check`.
```xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.2//EN"
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd";>
<module name="Checker">
<module name="Header">
<property name="headerFile" value="${config_loc}/asf.header"/>
<property name="fileExtensions" value="java"/>
</module>
</module>
```
And I manually checked changes with `git diff master...HIVE-29245-asf-header`
@Aggarwal-Raghav
Just a clarification, does it mean we should update our expected files?
Probably no.
-
[storage-api](https://github.com/apache/hive/blob/master/storage-api/checkstyle/asf.header)
-
[standalone-metastore](https://github.com/apache/hive/blob/master/standalone-metastore/checkstyle/asf.header)
- [Everything
else](https://github.com/apache/hive/blob/master/checkstyle/asf.header)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
