okumin commented on PR #6115: URL: https://github.com/apache/hive/pull/6115#issuecomment-3388082951
@InvisibleProgrammer Thanks for the feedback. I added what commands are used or what are hand-maded. ``` commit c71e63c1d4b44137589519d13608eb197a03279b (HEAD -> HIVE-29245-regex-indent, origin/HIVE-29245-regex-indent) Author: okumin <[email protected]> Date: Thu Oct 9 14:00:18 2025 +0900 Don't run RAT for checkstyle commit 1292595d685be4056fc7ff9ad5d73a3ae6aaad1c Author: okumin <[email protected]> Date: Thu Oct 9 13:40:43 2025 +0900 Add RegexpHeader commit 76a30b762d486cc7d83235f2babcf0856a8fd844 Author: okumin <[email protected]> Date: Thu Oct 9 13:36:12 2025 +0900 Modify irregular files by hand commit 0c349da0c8f3d5cd337d07613956c367ff2a2168 Author: okumin <[email protected]> Date: Thu Oct 9 13:19:59 2025 +0900 Add asterisk to some irregular files By hand commit 6a1b7ae9061cb61b15d7c75002e379014efbeaad Author: okumin <[email protected]> Date: Thu Oct 9 13:11:45 2025 +0900 Normalize # of indents of irregular LLAP patterns git ls-files '*.java' | grep -v 'src/gen/thrift' | grep -v '^iceberg/' \ | xargs perl -pi -e 's|^ \* you may not use this file except in compliance with the License\.$| * you may not use this file except in compliance with the License.|' git ls-files '*.java' | grep -v 'src/gen/thrift' | grep -v '^iceberg/' \ | xargs perl -pi -e 's|^ \* You may obtain a copy of the License at$| * You may obtain a copy of the License at|' commit f90704c64312f53ef980fb52822dc2c9e9acd5e2 Author: okumin <[email protected]> Date: Thu Oct 9 13:02:35 2025 +0900 Reduce extra indents, irregular pattern 1 git ls-files '*.java' | grep -v 'src/gen/thrift' | grep -v '^iceberg/' \ | xargs perl -pi -e 's|^ \* \* Licensed to the Apache Software Foundation \(ASF\) under one$| * * Licensed to the Apache Software Foundation (ASF) under one|' git ls-files '*.java' | grep -v 'src/gen/thrift' | grep -v '^iceberg/' \ | xargs perl -pi -e 's|^ \* \* or more contributor license agreements\. See the NOTICE file$| * * or more contributor license agreements. See the NOTICE file|' git ls-files '*.java' | grep -v 'src/gen/thrift' | grep -v '^iceberg/' \ | xargs perl -pi -e 's|^ \* \* distributed with this work for additional information$| * * distributed with this work for additional information|' git ls-files '*.java' | grep -v 'src/gen/thrift' | grep -v '^iceberg/' \ | xargs perl -pi -e 's|^ \* \* regarding copyright ownership\. The ASF licenses this file$| * * regarding copyright ownership. The ASF licenses this file|' ``` And the diff is 500 lines. Is this still huge? In that case, I will split it more. ``` % git diff master...HIVE-29245-regex-indent -w | wc -l 555 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
