saihemanth-cloudera commented on code in PR #6089:
URL: https://github.com/apache/hive/pull/6089#discussion_r2414814623
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -1953,306 +1942,6 @@ private List<ColumnStatisticsObj>
aggrStatsUseJava(String catName, String dbName
areAllPartsFound, useDensityFunctionForNDVEstimation, ndvTuner);
}
- private List<ColumnStatisticsObj> aggrStatsUseDB(String catName, String
dbName,
Review Comment:
> Do we have tests using other dbs than Derby and the PostgreSQL image?
Oracle has a 1000 parameter limit. It would be nice to run performance
testing on PostgreSQL, Oracle, mysql before removing this optimization.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -1953,306 +1942,6 @@ private List<ColumnStatisticsObj>
aggrStatsUseJava(String catName, String dbName
areAllPartsFound, useDensityFunctionForNDVEstimation, ndvTuner);
}
- private List<ColumnStatisticsObj> aggrStatsUseDB(String catName, String
dbName,
Review Comment:
> Do we have tests using other dbs than Derby and the PostgreSQL image?
Oracle has a 1000 parameter limit. It would be nice to run performance
testing on PostgreSQL, Oracle, mysql before removing this optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
