ramitg254 commented on code in PR #6089:
URL: https://github.com/apache/hive/pull/6089#discussion_r2486500601


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -1953,306 +1942,6 @@ private List<ColumnStatisticsObj> 
aggrStatsUseJava(String catName, String dbName
         areAllPartsFound, useDensityFunctionForNDVEstimation, ndvTuner);
   }
 
-  private List<ColumnStatisticsObj> aggrStatsUseDB(String catName, String 
dbName,

Review Comment:
   @saihemanth-cloudera  as per HIVE-16997 bit vector is set to true for tpcds 
tests even if default value is false making it go back to `aggrStatsUseJava` 
and even if i set it to false to fall back to `aggrStatsUseDB` the results are 
different for .out files of tpcds queries.
   So my concern is do I need to first obtain those different results generated 
via `aggrStatsUseDB` and then run performance testing while validating with 
those results.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to