simhadri-g commented on code in PR #68:
URL: https://github.com/apache/hive-site/pull/68#discussion_r2470956523
##########
themes/hive/layouts/partials/menu.html:
##########
@@ -67,6 +67,8 @@
<ul class="dropdown-menu"
aria-labelledby="devDropdown">
<li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.gettingStarted }}">Getting
Started</a></li>
<li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.docker }}">Quickstart with
Docker</a></li>
+ <li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.dockerGravitino }}">Quickstart
with Docker: Hive with REST Catalog Client + Gravitino + Keyclock</a></li>
Review Comment:
The link `href="{{.Site.BaseURL}}{{ .Site.Params.navbar.dockerGravitino }}`
is needed to redirect to the correct markdown page
Also this is a drop down text, better to keep it short like `quickstart:
hive rest catalog`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
