deniskuzZ commented on code in PR #68:
URL: https://github.com/apache/hive-site/pull/68#discussion_r2472213357


##########
themes/hive/layouts/partials/menu.html:
##########
@@ -67,6 +67,8 @@
                         <ul class="dropdown-menu" 
aria-labelledby="devDropdown">
                             <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.gettingStarted }}">Getting 
Started</a></li>
                             <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.docker }}">Quickstart with 
Docker</a></li>
+                            <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.dockerGravitino }}">Quickstart 
with Docker: Hive with REST Catalog Client + Gravitino + Keyclock</a></li>

Review Comment:
   PS: we should probably add version to the page title (i.e Apache Hive 4.0) 
and create similar change log for 4.2.
   
   - https://hive.apache.org/docs/latest/overview-of-major-changes/
   - https://hive.apache.org/docs/latest/changelog/
   
   btw, I would drop this change log page from documentation and link it in 
releases instead of JIRA changelog. I think @ayushtkn was using some tool to 
generate changelog page from Jira change log.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to