thomasrebele commented on code in PR #6177: URL: https://github.com/apache/hive/pull/6177#discussion_r2534122524
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/DecimalComparator.java: ########## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.metastore.columnstats; + +import org.apache.hadoop.hive.metastore.api.Decimal; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.util.Comparator; +import java.util.function.Consumer; + +public class DecimalComparator implements Comparator<Decimal> { + + public static final DecimalComparator INSTANCE = new DecimalComparator(); + + public static final byte PAD_POS = (byte) 0; + public static final byte PAD_NEG = (byte) -1; // or 0xff in hexadecimal + + public enum Approach { + UNKNOWN, SIGN, EQSCALE, LOG_ZERO, BITLOG_A, BITLOG_B, FALLBACK; + + public static final int LEN = Approach.values().length; + } + + /** + * Notifies the caller which approach was chosen. + * + * <p>It is used by tests. + */ + interface ApproachInfoCallback extends Consumer<Approach> { + } + + @Override + public int compare(Decimal o1, Decimal o2) { + return compareInner(o1, o2, true, null); + } + + private boolean isNotNegative(byte[] unscaled) { + if (unscaled.length == 0) { + return true; + } + return 0 == (Byte.toUnsignedInt(unscaled[0]) >> 7); + } + + int compareInner(Decimal d1, Decimal d2, boolean useFallback, ApproachInfoCallback aic) { Review Comment: Indeed, the naming could be better. I'll replace the custom comparator with HiveDecimal#compareTo, so the class will be deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
