thomasrebele commented on code in PR #6177:
URL: https://github.com/apache/hive/pull/6177#discussion_r2534053524
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/ShowUtils.java:
##########
@@ -233,12 +233,7 @@ public static String[] extractColumnValues(FieldSchema
column, boolean isColumnS
}
public static String convertToString(Decimal val) {
- if (val == null) {
- return "";
- }
-
- HiveDecimal result = HiveDecimal.create(new BigInteger(val.getUnscaled()),
val.getScale());
- return (result != null) ? result.toString() : "";
+ return MetaStoreServerUtils.decimalToString(val);
Review Comment:
ShowUtils is not accessible from DecimalColumnStatsMergerTest. Moving the
logic of the method to MetaStoreServerUtils allows it to use it in the test as
well, avoiding duplication of the same logic in different places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
