InvisibleProgrammer commented on code in PR #6203:
URL: https://github.com/apache/hive/pull/6203#discussion_r2542044852
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -72,12 +72,22 @@ static abstract class TestKeyIndexBuilder
}
void createTestAcidFile(Path path, int numRows, TestKeyIndexBuilder
indexBuilder) throws Exception {
+ createTestAcidFile(path, numRows, indexBuilder, false);
+ }
+
+ void createTestAcidFile(Path path,
+ int numRows,
+ TestKeyIndexBuilder indexBuilder,
+ boolean acidMetadataLowerCase) throws Exception {
FileSystem fs = path.getFileSystem(conf);
fs.delete(path, true);
String typeStr = "struct<operation:int," +
"originalTransaction:bigint,bucket:int,rowId:bigint," +
"currentTransaction:bigint," +
"row:struct<a:int,b:struct<c:int>,d:string>>";
+ if (acidMetadataLowerCase) {
+ typeStr = typeStr.toLowerCase();
+ }
Review Comment:
It would give more control to the caller. And also, it would led to
modifying the 4 already existing test cases.
Does it worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
