InvisibleProgrammer commented on code in PR #6203:
URL: https://github.com/apache/hive/pull/6203#discussion_r2542061176
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java:
##########
@@ -219,6 +229,27 @@ public void testValidKeyIndex() throws Exception {
fixValidIndex(testFilePath);
}
+ @Test
+ public void testValidKeyIndexWithAcidMetadataLowerCase() throws Exception {
+ // Try with 0 row file.
+ createTestAcidFile(testFilePath, 0, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Try single stripe
+ createTestAcidFile(testFilePath, 100, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
+
+ // Multiple stripes
+ createTestAcidFile(testFilePath, 12000, new GoodKeyIndexBuilder(), true);
+ checkValidKeyIndex(testFilePath);
+ // Attempting to fix a valid - should not result in a new file.
+ fixValidIndex(testFilePath);
Review Comment:
I could. The question is: does it worth it?
It follows the exact same pattern as the other test cases.
If I separate for three test cases, it will lead to almost doubling the
existing test cases in the class.
My personal opinion is a single test case should contain only one assertion,
not multiple ones. But in that case, I wanted to choose an approach that
matches with the existing code.
Are you sure that I would do the split?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
