deniskuzZ commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2592243021
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##########
@@ -202,6 +203,42 @@ public void preCreateTable(CreateTableRequest request) {
// Remove hive primary key columns from table request, as iceberg doesn't
support hive primary key.
request.setPrimaryKeys(null);
setSortOrder(hmsTable, schema, catalogProperties);
+
+ setWriteMetadataCleanupConfig(hmsTable.getParameters(),
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED,
Review Comment:
why not move everything into setWriteMetadataCleanupConfig?
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##########
@@ -202,6 +203,42 @@ public void preCreateTable(CreateTableRequest request) {
// Remove hive primary key columns from table request, as iceberg doesn't
support hive primary key.
request.setPrimaryKeys(null);
setSortOrder(hmsTable, schema, catalogProperties);
+
+ setWriteMetadataCleanupConfig(hmsTable.getParameters(),
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED,
Review Comment:
why not move everything into setWriteMetadataCleanupConfigs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
