difin commented on code in PR #6218:
URL: https://github.com/apache/hive/pull/6218#discussion_r2593320970
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -95,6 +96,7 @@ protected Table createTable(Hive hive, Database db) throws
HiveException {
table.setProperty(hive_metastoreConstants.META_TABLE_NAME,
QUERY_HISTORY_DB_TABLE_NAME);
table.setFields(schema.getFields());
+ table.setProperty(ICEBERG_METADATA_CLEANUP_CONFIG, "false");
Review Comment:
This property can be defined as a table property or on the session level.
In `BaseHiveIcebergMetaHook.preCreateTable()` it retrieves this prop from
table properties or session and sets it in the catalog properties, from there
it gets to the Iceberg table properties. This is the same behavior as for the
other iceberg properties.
I haven't traced how exactly it is propagated to iceberg table properties
from catalog properties, but verified this in testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
