mdayakar commented on PR #6239: URL: https://github.com/apache/hive/pull/6239#issuecomment-3675144640
Hi @Aggarwal-Raghav , I am not a vectorization feature expert but as per code changes I feel you missed below places adding DATE HashTableKeyType, please check. 1. [CheckFastRowHashMap.java](https://github.com/apache/hive/blob/90bf40799b06a965e7ff0f74b503e9251e95bfd5/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/CheckFastRowHashMap.java#L332-L368) 2. [VectorMapJoinOptimizedLongHashMap.java](https://github.com/apache/hive/blob/90bf40799b06a965e7ff0f74b503e9251e95bfd5/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedLongHashMap.java#L76-L94) 3. [VectorMapJoinOptimizedLongHashMap.java](https://github.com/apache/hive/blob/90bf40799b06a965e7ff0f74b503e9251e95bfd5/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedLongHashMap.java#L110-L128 ) Also I could see there are many UT test cases, may be you can add more test cases related DATE HashTableKeyType. For example [MapJoinTestConfig.java](https://github.com/apache/hive/blob/90bf40799b06a965e7ff0f74b503e9251e95bfd5/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/MapJoinTestConfig.java#L381-L402) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
