Aggarwal-Raghav commented on code in PR #6239: URL: https://github.com/apache/hive/pull/6239#discussion_r2659817027
########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/optimized/VectorMapJoinOptimizedLongHashMap.java: ########## Review Comment: Ack, it's doable as well. IMO it's better to move class from ``` package org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast => package org.apache.hadoop.hive.ql.exec.vector.mapjoin ``` and rename it from `VectorMapJoinFastLongHashUtil => VectorMapJoinLongHashUtil` As there is clear segregation between `fast` and `optimized` flow , importing `org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.VectorMapJoinFastLongHashUtil#deserializeLongKey` in `org.apache.hadoop.hive.ql.exec.vector.mapjoin.optimized.VectorMapJoinOptimizedLongHashMap` can make it confusing. Let me know on this. ########## ql/src/test/queries/clientpositive/vector_full_outer_join_date.q: ########## @@ -0,0 +1,29 @@ +set hive.optimize.dynamic.partition.hashjoin=true; +set hive.auto.convert.join=true; + +-- Test Date column +create table tbl1 (id int, event_date date); +create table tbl2 (id int, event_date date); + +insert into tbl1 values (1, '2023-01-01'), (2, '2023-01-02'), (3, '2023-01-03'); +insert into tbl2 values (2, '2023-01-02'), (3, '2023-01-04'), (4, '2023-01-05'); + +select tbl1.id, tbl1.event_date from tbl1 full outer join tbl2 on tbl1.event_date = tbl2.event_date order by tbl1.id; Review Comment: yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
