zabetak commented on code in PR #6202:
URL: https://github.com/apache/hive/pull/6202#discussion_r2675925598
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java:
##########
@@ -1322,6 +1330,15 @@ private static void
runTopNKeyOptimization(OptimizeTezProcContext procCtx)
ogw.startWalking(topNodes, null);
}
+ private static boolean hasPTFReduceSink(OptimizeTezProcContext ctx) {
+ for (ReduceSinkOperator rs : ctx.visitedReduceSinks) {
+ if (rs.getConf().isPTFReduceSink()) {
+ return true;
+ }
+ }
+ return false;
+ }
+
Review Comment:
I am not sure to what extend the claim that "there is not much performance
issues with TopNKey enabled" holds. As mentioned in other comments first we
have to confirm when/if TopNKey is efficient for PTF reducers and then decide
to skip or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
