ramitg254 commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2695163520


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java:
##########
@@ -127,7 +127,7 @@ private Table getTable() throws HiveException {
   private Partition getPartition(Table table) throws HiveException {
     Partition part = null;
     if (desc.getPartitionSpec() != null) {
-      part = context.getDb().getPartition(table, desc.getPartitionSpec(), 
false);
+      part = context.getDb().getPartition(table, desc.getPartitionSpec());

Review Comment:
   `getPartition` method without  forceCreate flag handles non-native tables as 
well pass the flag as false as it is right now for native hms backed tables
   that's why i used the `getPartition` implementation without that flag
   
   ```
   public Partition getPartition(Table tbl, Map<String, String> partSpec) 
throws HiveException {
       if (tbl.hasNonNativePartitionSupport()) {
         return tbl.getStorageHandler().getPartition(tbl, partSpec, 
Context.RewritePolicy.get(conf));
       } else {
         return getPartition(tbl, partSpec, false);
       }
     }
   ```
     
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to