ramitg254 commented on code in PR #6259:
URL: https://github.com/apache/hive/pull/6259#discussion_r2695362985
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -987,6 +987,11 @@ default boolean
isPartitioned(org.apache.hadoop.hive.ql.metadata.Table table) {
return false;
}
+ default boolean isPartitionPresent(org.apache.hadoop.hive.ql.metadata.Table
table,
Review Comment:
actually I added it because of these considerations:
1. `getPartition` in iceberg returns dummy partition corresponding to that
partSpec without checking it is already present or not and this functionality
is used in other places like for insert queries for iceberg tables as well
that's why I added this separate method
2. I also thought of adding this method in `Hive.java ` instead of storage
handler but that would be too specific and if we have newer storage handler in
future then it can have some different implementation to check the partition is
present or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
