deniskuzZ commented on code in PR #6292:
URL: https://github.com/apache/hive/pull/6292#discussion_r2760692171
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -612,9 +612,10 @@ private void commit(SnapshotUpdate<?> update) {
*/
private void commitCompaction(Table table, Long snapshotId, long startTime,
FilesForCommit results,
String partitionPath, long fileSizeThreshold) {
- List<DataFile> existingDataFiles =
IcebergCompactionUtil.getDataFiles(table, partitionPath, fileSizeThreshold);
+ List<DataFile> existingDataFiles =
+ IcebergCompactionUtil.getDataFiles(table, snapshotId, partitionPath,
fileSizeThreshold);
List<DeleteFile> existingDeleteFiles = fileSizeThreshold == -1 ?
- IcebergCompactionUtil.getDeleteFiles(table, partitionPath) :
Collections.emptyList();
+ IcebergCompactionUtil.getDeleteFiles(table, snapshotId, partitionPath)
: Collections.emptyList();
Review Comment:
please add test. see as an example
TestConflictingDataFiles#testConflictingUpdateAndDelete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
