deniskuzZ commented on code in PR #6292:
URL: https://github.com/apache/hive/pull/6292#discussion_r2760699005
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergCompactionUtil.java:
##########
@@ -88,10 +89,10 @@ public static List<DataFile> getDataFiles(Table table,
String partitionPath, lon
* @param table the iceberg table
* @param partitionPath partition path
*/
- public static List<DeleteFile> getDeleteFiles(Table table, String
partitionPath) {
+ public static List<DeleteFile> getDeleteFiles(Table table, Long snapshotId,
String partitionPath) {
Table deletesTable =
MetadataTableUtils.createMetadataTableInstance(table,
MetadataTableType.POSITION_DELETES);
- CloseableIterable<ScanTask> deletesScanTasks =
deletesTable.newBatchScan().planFiles();
+ CloseableIterable<ScanTask> deletesScanTasks =
deletesTable.newBatchScan().useSnapshot(snapshotId).planFiles();
Review Comment:
why do you use here newBatchScan() and in getDataFiles newScan()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
