zhangbutao commented on code in PR #6314:
URL: https://github.com/apache/hive/pull/6314#discussion_r2887200437
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -8276,15 +8276,26 @@ public SerDeInfo get_serde(GetSerdeRequest rqst) throws
TException {
}
@Override
- public LockResponse get_lock_materialization_rebuild(String dbName, String
tableName, long txnId)
- throws TException {
- return getTxnHandler().lockMaterializationRebuild(dbName, tableName,
txnId);
+ public LockResponse get_lock_materialization_rebuild(String dbName, String
tableName, long txnId) throws TException {
Review Comment:
Add Deprecated
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -1057,9 +1070,11 @@ public long getLatestTxnIdInConflict() throws
LockException {
}
}
- private boolean heartbeatMaterializationRebuildLock(String dbName, String
tableName, long txnId) throws LockException {
+ private boolean heartbeatMaterializationRebuildLock(String catName, String
dbName, String tableName,
Review Comment:
Add Deprecated
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -1024,11 +1029,18 @@ private long getTableWriteId(String dbName, String
tableName, boolean allocateIf
}
@Override
- public LockResponse acquireMaterializationRebuildLock(String dbName, String
tableName, long txnId) throws LockException {
+ public LockResponse acquireMaterializationRebuildLock(String dbName, String
tableName,
Review Comment:
Add Deprecated
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -8276,15 +8276,26 @@ public SerDeInfo get_serde(GetSerdeRequest rqst) throws
TException {
}
@Override
- public LockResponse get_lock_materialization_rebuild(String dbName, String
tableName, long txnId)
- throws TException {
- return getTxnHandler().lockMaterializationRebuild(dbName, tableName,
txnId);
+ public LockResponse get_lock_materialization_rebuild(String dbName, String
tableName, long txnId) throws TException {
+ return get_lock_materialization_rebuild_req(new
LockMaterializationRebuildRequest(DEFAULT_CATALOG_NAME, dbName,
+ tableName, txnId));
}
@Override
- public boolean heartbeat_lock_materialization_rebuild(String dbName, String
tableName, long txnId)
+ public LockResponse
get_lock_materialization_rebuild_req(LockMaterializationRebuildRequest rqst)
Review Comment:
Add Deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
