Copilot commented on code in PR #6314:
URL: https://github.com/apache/hive/pull/6314#discussion_r2887980746
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -1301,6 +1303,14 @@ struct ShowLocksResponseElement {
14: optional i64 blockedByExtId,
15: optional i64 blockedByIntId,
16: optional i64 lockIdInternal,
+ 17: required string catname,
+}
+
+struct LockMaterializationRebuildRequest {
+ 1: required string catName,
+ 2: required string dbName,
+ 3: required string tableName,
+ 4: required i64 tnxId,
}
Review Comment:
`LockMaterializationRebuildRequest` uses field name `tnxId`, which looks
like a typo for `txnId`. Since this becomes part of the public Thrift/Proto API
and is hard to change later without breaking clients, consider renaming it to
`txnId` now and updating generated code/usages accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
