mdayakar commented on code in PR #6361:
URL: https://github.com/apache/hive/pull/6361#discussion_r2971271277
##########
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java:
##########
@@ -45,13 +45,7 @@
public abstract class ExecuteStatementOperation extends Operation {
protected String statement = null;
- public ExecuteStatementOperation(HiveSession parentSession, String statement,
- Map<String, String> confOverlay) {
- super(parentSession, confOverlay, OperationType.EXECUTE_STATEMENT);
- this.statement = statement;
- }
-
- public ExecuteStatementOperation(HiveSession parentSession, String
statement, Map<String, String> confOverlay, boolean runInBackground, boolean
generateNewQueryId) {
+ public ExecuteStatementOperation(HiveSession parentSession, String
statement, Map<String, String> confOverlay, boolean generateNewQueryId) {
Review Comment:
Thanks for the review @soumyakanti3578 . Changed the variable
`generateNewQueryId` to `embedded` to match with other places. I feel
`embedded` is ok here as it denotes the current operation is getting executed
as embedded operation of another operation so don't want to change to
`isHplSqlMode` even though its added as a part of HPLSQL integration within
HS2. Hope that is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
