soumyakanti3578 commented on code in PR #6361:
URL: https://github.com/apache/hive/pull/6361#discussion_r2976230988
##########
service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java:
##########
@@ -45,13 +45,7 @@
public abstract class ExecuteStatementOperation extends Operation {
protected String statement = null;
- public ExecuteStatementOperation(HiveSession parentSession, String statement,
- Map<String, String> confOverlay) {
- super(parentSession, confOverlay, OperationType.EXECUTE_STATEMENT);
- this.statement = statement;
- }
-
- public ExecuteStatementOperation(HiveSession parentSession, String
statement, Map<String, String> confOverlay, boolean runInBackground, boolean
generateNewQueryId) {
+ public ExecuteStatementOperation(HiveSession parentSession, String
statement, Map<String, String> confOverlay, boolean generateNewQueryId) {
Review Comment:
Thanks @mdayakar , renaming it to `embedded` is fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
