rtrivedi12 commented on code in PR #6381:
URL: https://github.com/apache/hive/pull/6381#discussion_r2989537769
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -66,6 +67,9 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
config.setPoolName(poolName);
}
+ long connectionTimeout = hdpConfig.getLong(HIKARI + ".connectionTimeout",
DEFAULT_CONNECTION_TIMEOUT_MS);
Review Comment:
Thanks for the feedback @ayushtkn! Initially, connectionTimeout was handled
like other HikariCP properties (raw numbers passed through Properties), but it
definitely makes sense to use getTimeDuration() since we now explicitly set it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
