abstractdog commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3001466607
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/drop/DropDatabaseOperation.java:
##########
@@ -53,7 +53,7 @@ public int execute() throws HiveException {
if (LlapHiveUtils.isLlapMode(context.getConf())) {
ProactiveEviction.Request.Builder llapEvictRequestBuilder =
ProactiveEviction.Request.Builder.create();
- llapEvictRequestBuilder.addDb(dbName); // TODO catalog. add catalog
for the cache. Depend on HIVE-29281
+ llapEvictRequestBuilder.addDb(catName, dbName);
Review Comment:
yeah, it might make sense theoretically
non-native catalogs can also eventually bring actual data to the LLAP
daemons that might be suitable for caching, as long as e.g. the file format is
compatible with LLAP IO caching...and if that's the case, the same eviction
policies and behavior should apply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
