Neer393 commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3004384058
##########
ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java:
##########
@@ -233,19 +258,26 @@ public
List<LlapDaemonProtocolProtos.EvictEntityRequestProto> toProtoRequests()
* @return true if cacheTag matches and the related buffer is eligible for
proactive eviction, false otherwise.
*/
public boolean isTagMatch(CacheTag cacheTag) {
+ String catalog = getSingleCatalogName();
Review Comment:
I don't get how am I using the default catalog here ?
As per the flow I understand, entities will have multiple catalogs, under
each catalog there may be multiple dbs and under each db there may be multiple
tables and their partitions
Now `toProtoRequests()` will separately create proto messages for each of
the [catalogname, dbname and list of tables] and send it to the LLAP daemons.
So the LLAP daemons will convert them to entities using `fromProtoRequest()` so
ideally when `isTagMatch()` is called, it would essentially contain only one
catalog, one db under it and multiple tables under it. So `getSingleCatalog()`
and `getSingleDb()` would work correctly as expected.
And nowhere I see a hardcoding for the DEFAULT WAREHOUSE.
Please let me know if I am missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
