deniskuzZ commented on code in PR #6390:
URL: https://github.com/apache/hive/pull/6390#discussion_r3020603785
##########
packaging/src/docker/start-llap.sh:
##########
@@ -0,0 +1,14 @@
+#!/usr/bin/env bash
+
+# Starts an LLAP cluster.
+# Query execution is done in LLAP daemons.
+
+# Cleanup previous containers and images
+docker compose --profile llap down --rmi local
Review Comment:
no strong feelings, however, i my opinion single start script
````
./start-hive.sh --llap
````
is more user friendly, WDYT?
````
#!/usr/bin/env bash
set -e
MODE="container"
PROFILE=""
for arg in "$@"; do
case "$arg" in
--llap)
MODE="llap"
PROFILE="--profile llap"
;;
*)
echo "Unknown option: $arg"
exit 1
;;
esac
done
export HIVE_EXECUTION_MODE="$MODE"
echo "Starting Hive cluster (mode=$HIVE_EXECUTION_MODE)"
docker compose $PROFILE up -d
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
