abstractdog commented on code in PR #6390:
URL: https://github.com/apache/hive/pull/6390#discussion_r3021459638
##########
packaging/src/docker/entrypoint.sh:
##########
@@ -67,6 +68,59 @@ function initialize_hive {
fi
}
+function run_llap {
+ export HIVE_ZOOKEEPER_QUORUM="${HIVE_ZOOKEEPER_QUORUM:-zookeeper:2181}"
+ export
HIVE_LLAP_DAEMON_SERVICE_HOSTS="${HIVE_LLAP_DAEMON_SERVICE_HOSTS:-@llap0}"
Review Comment:
not necessarily I believe: `entrypoint.sh` is going to be used in all
different setups, not limited to the current docker-compose: taking care of
defaults before handling the xml template might make sense later too when this
is used in a real k8s environment for instance (or at least, my plan is to
reuse this image + entrypoint in different environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
