InvisibleProgrammer commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3043434150
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:
##########
@@ -2662,6 +2682,10 @@ public void testQueryTimeout() throws Exception {
fail("Expecting SQLTimeoutException");
} catch (SQLTimeoutException e) {
assertNotNull(e);
+ assertTrue("Message should reflect JDBC query timeout (1s): " +
e.getMessage(),
Review Comment:
Can you show us an example about the whole output that demonstrates the
change?
I wonder if it is possible to get any number other than the timeout in the
message. Like a timestamp or maybe a query id, host name, etc. Asserting to a
single number in a string looks a little bit fragile to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
