InvisibleProgrammer commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3043665823
##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -163,6 +164,12 @@
*/
public class HiveConnection implements java.sql.Connection {
private static final Logger LOG =
LoggerFactory.getLogger(HiveConnection.class);
+
+ /**
+ * Sentinel: no {@code SET hive.query.timeout.seconds} has been observed on
this connection yet.
+ */
+ static final long SESSION_QUERY_TIMEOUT_NOT_TRACKED = -1L;
+ private final AtomicLong sessionQueryTimeoutSeconds = new
AtomicLong(SESSION_QUERY_TIMEOUT_NOT_TRACKED);
Review Comment:
Thinking out loud: I wonder if a connection can have concurrency issue: I
mean, you can have multiple individual connections to Hive, but inside a
connection itself, can we have multiple hive statements in parallel?
I have no such use case in my mind, but let me ping Ayush about this
question.
@ayushtkn , what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
