VenuReddy2103 commented on code in PR #6399:
URL: https://github.com/apache/hive/pull/6399#discussion_r3056266001
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/functions/MarkCleanedFunction.java:
##########
@@ -50,7 +50,7 @@ public MarkCleanedFunction(CompactionInfo info) {
public Void execute(MultiDataSourceJdbcResource jdbcResource) throws
MetaException {
NamedParameterJdbcTemplate jdbcTemplate = jdbcResource.getJdbcTemplate();
MapSqlParameterSource param;
- if (!info.isAbortedTxnCleanup()) {
+ if (!info.isAbortedTxnCleanup() && !info.isSoftDelete()) {
Review Comment:
If it is not soft delete, we want to add a row to COMPLETED_COMPACTIONS,
delete row from `COMPACTION_QUEUE`(in
`removeCompactionAndAbortRetryEntries()`), delete rows from
`COMPLETED_TXN_COMPONENTS` and `TXN_COMPONENTS` too. Have refactored a bit to
avoid !info.isSoftDelete() at too many places now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
