deniskuzZ commented on code in PR #6399:
URL: https://github.com/apache/hive/pull/6399#discussion_r3067175788
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/CompactionCleaner.java:
##########
@@ -158,6 +158,7 @@ private void clean(CompactionInfo ci, long minOpenTxn,
boolean metricsEnabled) t
cleanUsingAcidDir(ci, t, path, cleanerWaterMark);
}
} else {
+ ci.setSoftDelete(true);
Review Comment:
could we set `softDelete` inside cleanUsingLocation? i think we call in only
in case of `softDelete`
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/CompactionCleaner.java:
##########
@@ -158,6 +158,7 @@ private void clean(CompactionInfo ci, long minOpenTxn,
boolean metricsEnabled) t
cleanUsingAcidDir(ci, t, path, cleanerWaterMark);
}
} else {
+ ci.setSoftDelete(true);
Review Comment:
could we set `softDelete` flag inside cleanUsingLocation? i think we call in
only in case of `softDelete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
