difin opened a new pull request, #6474:
URL: https://github.com/apache/hive/pull/6474
…lient
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
- Add Iceberg REST access delegation support in Hive: map
`rest.access-delegation` to the `X-Iceberg-Access-Delegation` header (with an
escape hatch for an explicit `header.X-Iceberg-Access-Delegation` property) so
catalogs can return vended storage credentials per the Iceberg REST spec.
- Extend Gravitino LLAP qtest
(`TestIcebergRESTCatalogGravitinoLlapLocalCliDriver`) to run against MinIO + S3
warehouse with Gravitino s3-secret-key vending and OAuth2; configure host-side
S3A and Iceberg S3FileIO for the published MinIO port so Tez/LLAP on the host
work reliably.
- Add a small RESTCatalog smoke check in test setup (vended S3 / S3FileIO)
before the q-files run.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
- Hive’s Iceberg REST client must send the delegation header so Gravitino
(and similar catalogs) can attach vended S3 configuration to responses; without
it, vended-credential flows cannot be used from Hive as intended.
- The Gravitino integration test needs a realistic S3 + vending layout and
host-safe MinIO/Tez configuration so CI does not depend on brittle host hacks
(e.g. resolving minio only inside Docker).
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Users configuring an Iceberg REST catalog in Hive can set
`iceberg.catalog.<name>.rest.access-delegation` (e.g. vended-credentials); Hive
will pass that through as `X-Iceberg-Access-Delegation` on REST requests unless
they set the header property explicitly. No change for catalogs that do not use
this property.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
- TestHiveRESTCatalogClient (unit) for delegation / header mapping.
- TestIcebergRESTCatalogGravitinoLlapLocalCliDriver (LLAP qtest:
iceberg_rest_catalog_gravitino.q) with Gravitino + MinIO + OAuth2 + vending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
