okumin commented on code in PR #6474:
URL: https://github.com/apache/hive/pull/6474#discussion_r3428759632
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveTableUtil.java:
##########
@@ -244,6 +244,7 @@ public static Table deserializeTable(Configuration config,
String name) {
table = readTableObjectFromFile(location, config);
}
checkAndSetIoConfig(config, table);
+ IcebergVendedCredentialUtil.applyFromJobConf(table, config);
Review Comment:
Most Iceberg clients don't need to ser/de credentials on their own,
probably. We need it. That's because we serialize an Iceberg table in Hadoop's
configuration as an intermediate expression? I guess we should store the
credentials as they are and just restore them, without refining or normalizing
the content on the Hive side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
