tanishq-chugh commented on code in PR #6471:
URL: https://github.com/apache/hive/pull/6471#discussion_r3290536941
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnhex.java:
##########
@@ -42,32 +42,59 @@
public class UDFUnhex extends UDF {
/**
- * Convert every two hex digits in s into.
- *
+ * Convert every two hex digits in s into a byte.
*/
public byte[] evaluate(Text s) {
if (s == null) {
return null;
}
- // append a leading 0 if needed
- String str;
- if (s.getLength() % 2 == 1) {
- str = "0" + s.toString();
- } else {
- str = s.toString();
+ int len = s.getLength();
+ if (len == 0) {
+ return new byte[0];
}
- byte[] result = new byte[str.length() / 2];
- for (int i = 0; i < str.length(); i += 2) {
- try {
- result[i / 2] = ((byte) Integer.parseInt(str.substring(i, i + 2), 16));
- } catch (NumberFormatException e) {
- // invalid character present, return null
+ byte[] textBytes = s.getBytes();
+
+ // (len + 1) / 2 ensures right size for odd lengths
+ byte[] result = new byte[(len + 1) / 2];
+
+ int i = 0;
+ int resIdx = 0;
+
+ // If length is odd, the first character acts as the first byte avoiding
adding "0" prefix
+ if (len % 2 != 0) {
+ int val = decodeHexChar(textBytes[i++]);
+ if (val == -1) {
+ return null;
+ }
Review Comment:
Hi @soumyakanti3578 , Thanks for checking this!
Added the case in commit:
[a530e08](https://github.com/apache/hive/pull/6471/commits/a530e083b55cf8ee5df198698d28a41b709e9329)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
