soumyakanti3578 commented on code in PR #6516:
URL: https://github.com/apache/hive/pull/6516#discussion_r3337889181
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -3072,6 +3072,11 @@ void parseJoinCondPopulateAlias(QBJoinTree joinTree,
ASTNode condn,
if (rightAliases.size() > rhssize) { // the new table is rhs table
rhsAlias = rightAliases.get(rightAliases.size() - 1);
+ } else if (condn.getChild(0).getType() ==
HiveParser.TOK_TABLE_OR_COL) {
+ String alias =
unescapeIdentifier(condn.getChild(0).getChild(0).getText().toLowerCase());
Review Comment:
I think we need a comment here to explain what this `else-if` branch is
doing, and why we couldn't simply rely on the recursive call to
`parseJoinCondPopulateAlias`.
Also, do you think we need to check for nulls anywhere in
`condn.getChild(0).getChild(0).getText()`? I am not sure if anything can be
null here, could you please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
