tanishq-chugh commented on code in PR #6516:
URL: https://github.com/apache/hive/pull/6516#discussion_r3342147950
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -3072,6 +3072,11 @@ void parseJoinCondPopulateAlias(QBJoinTree joinTree,
ASTNode condn,
if (rightAliases.size() > rhssize) { // the new table is rhs table
rhsAlias = rightAliases.get(rightAliases.size() - 1);
+ } else if (condn.getChild(0).getType() ==
HiveParser.TOK_TABLE_OR_COL) {
+ String alias =
unescapeIdentifier(condn.getChild(0).getChild(0).getText().toLowerCase());
Review Comment:
Hi @soumyakanti3578, Thanks for checking this!
Post your comment, i was going through the fix again and have found a better
way to fix the issue where we are using the existing recursive call itself,
this way the hardcoded code to fetch AST child written previously is avoided.
Please check it out and let me know your thoughts. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
