zabetak commented on code in PR #6515:
URL: https://github.com/apache/hive/pull/6515#discussion_r3340349982
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -452,6 +452,25 @@ public static void performMetadataDelete(Table
icebergTable, String branchName,
deleteFiles.deleteFromRowFilter(exp).commit();
}
+ /**
+ * Parses an Iceberg partition path into a Hive-compatible spec map.
Review Comment:
For non-Iceberg tables I assume that actual NULL values go into the default
partition (`hive.exec.default.partition.name`). I am trying to understand if
when we built the spec we should have the value of
`hive.exec.default.partition.name` or `null` and if it makes any difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
