zabetak commented on code in PR #6515:
URL: https://github.com/apache/hive/pull/6515#discussion_r3341002033
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -452,6 +452,25 @@ public static void performMetadataDelete(Table
icebergTable, String branchName,
deleteFiles.deleteFromRowFilter(exp).commit();
}
+ /**
+ * Parses an Iceberg partition path into a Hive-compatible spec map.
Review Comment:
I assume that you refer to
`org.apache.hadoop.hive.ql.optimizer.ppr.PartExprEvalUtils#evalExprWithPart`.
If the latter does not have null-awareness then it means that the wrong result
issue affects all partitioned tables and not only Iceberg.
I tried the following test case on master and it seems to confirm my
hypothesis.
```sql
create table pcr_t1 (key string, value string) partitioned by (ds string);
INSERT INTO pcr_t1 PARTITION (ds) SELECT 'A', 'V1', '2000-04-08' ;
INSERT INTO pcr_t1 PARTITION (ds) SELECT 'B', 'V2', 'null';
INSERT INTO pcr_t1 PARTITION (ds) SELECT 'C', 'V3', null;
select key, value, ds from pcr_t1 where ds is null;
```
Should we treat this as apart?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
