jlalwani-amazon commented on code in PR #6462:
URL: https://github.com/apache/hive/pull/6462#discussion_r3343394103
##########
metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java:
##########
@@ -83,8 +92,15 @@ private int getThreadId() {
return threadId.get();
}
- public static IMetaStoreClient getNonCachedHiveMetastoreClient(HiveConf
hiveConf) throws MetaException {
- return RetryingMetaStoreClient.getProxy(hiveConf, true);
+ public static IMetaStoreClient getNonCachedHiveMetastoreClient(final
HiveConf hiveConf)
+ throws MetaException {
+ String mscClassName = hiveConf.get(
+ MetastoreConf.ConfVars.METASTORE_CLIENT_IMPL.getHiveName(),
+ HiveMetaStoreClient.class.getName());
+ return RetryingMetaStoreClient.getProxy(hiveConf,
Review Comment:
Agreed, will switch to `new
HiveMetaStoreClientBuilder(hiveConf).newClient(true).withRetry(null).build()`.
Simpler and leverages the existing pluggable client support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
