jlalwani-amazon commented on code in PR #6462:
URL: https://github.com/apache/hive/pull/6462#discussion_r3343396488
##########
metastore/src/java/org/apache/hadoop/hive/metastore/HiveClientCache.java:
##########
@@ -526,5 +571,21 @@ protected void finalize() throws Throwable {
super.finalize();
}
}
+
+ @Override
+ public Object invoke(Object proxy, Method method, Object[] args) throws
Throwable {
+ try {
+ if (method.getDeclaringClass().isAssignableFrom(getClass())) {
Review Comment:
You're right, it's unnecessary. The proxy only exposes IMetaStoreClient
interface methods, and the only one we override is close() which is already
handled explicitly. Will remove the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
