InvisibleProgrammer commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3348056794
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -494,6 +504,21 @@ public void
commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
throw new IllegalStateException("Hive commit lock should already be
set");
}
commitLock.unlock();
+ if (BaseHiveIcebergMetaHook.isNativeIcebergLogicalView(hmsTable)) {
Review Comment:
I would add this part before commitLock.unlock. Yes, I know the current
implementation uses NoLock for native views but it can lead to hard to detect
issues in case we make a decision later to use actual locks for Iceberg views
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
