difin commented on PR #6449:
URL: https://github.com/apache/hive/pull/6449#issuecomment-4613276848
> @difin When compiling a query referencing an Iceberg logical views the
view definition query should come via Iceberg api from the Iceberg metadata
files not from the HMS backend db.
>
> In `HiveRESTCatalogClient.java` I found the implementation of this logic
>
> ```
> if (restCatalog instanceof ViewCatalog viewCatalog) {
> try {
> View icebergView = viewCatalog.loadView(id);
> return MetastoreUtil.toHiveView(icebergView, conf);
> } catch (NoSuchViewException viewMissing) {
> throw new NoSuchObjectException();
> }
> ```
>
> Maybe I'm missing something but haven't found the implementation of this
in case of HMS catalog via thrift. Could you please point it out?
Done - previously Hive was getting the view query definition that was stored
in HMS, now I made it retrieve view definition from Iceberg files in
https://github.com/apache/hive/pull/6449/changes#diff-427b2ffcf14c9599990dd80ea356f9fabbca2fae484f47ee8a3637263b2fa79eL504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
