ramitg254 commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3378762051
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AlterTableUtils.java:
##########
@@ -75,7 +75,7 @@ public static boolean isSchemaEvolutionEnabled(Table table,
Configuration conf)
}
public static boolean isFullPartitionSpec(Table table, Map<String, String>
partitionSpec) {
- for (FieldSchema partitionCol : table.getPartCols()) {
+ for (FieldSchema partitionCol : table.getPartitionKeys()) {
Review Comment:
getPartitionKeys() only give hms backed native part keys setted for `tTable`
whereas getPartCols() gives a generic one for any kind of table.
so was using it interchangeably to fix test failures which I later on
reverted as well but this one left so will check its implications after ci run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
