deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3379509177
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/rewrite/CopyOnWriteUpdateRewriter.java:
##########
@@ -90,12 +91,14 @@ public ParseUtils.ReparseResult rewrite(Context context,
UpdateStatement updateB
}
Map<Integer, ASTNode> setColExprs = new
HashMap<>(updateBlock.getSetCols().size());
- List<FieldSchema> nonPartCols = updateBlock.getTargetTable().getCols();
- for (int i = 0; i < nonPartCols.size(); i++) {
+ Table targetTable = updateBlock.getTargetTable();
+ List<FieldSchema> colsToLookUp =
targetTable.hasNonNativePartitionSupport() ? targetTable.getAllCols() :
Review Comment:
would we need this if we kept appendPartColsOfTargetTableWithComma for
nonNative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
