deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3380000206
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/RewriteSemanticAnalyzer.java:
##########
@@ -117,18 +117,24 @@ protected void analyzeRewrittenTree(ASTNode
rewrittenTree, Context rewrittenCtx)
*/
protected void checkValidSetClauseTarget(ASTNode colName, Table targetTable)
throws SemanticException {
String columnName = normalizeColName(colName.getText());
-
// Make sure this isn't one of the partitioning columns, that's not
supported.
+ boolean foundColumnInTargetTable = false;
Review Comment:
can we simplify
````
// Native partition columns cannot be updated; Iceberg partition columns are
regular updatable columns.
if (!targetTable.hasNonNativePartitionSupport() &&
targetTable.isPartitionKey(columnName)) {
throw new
SemanticException(ErrorMsg.UPDATE_CANNOT_UPDATE_PART_VALUE.getMsg());
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
