deniskuzZ commented on code in PR #6413:
URL: https://github.com/apache/hive/pull/6413#discussion_r3452468102
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -728,8 +750,50 @@ private boolean isField(String col) {
return false;
}
+ private void ensureColumnsIndexed() {
+ if (columnsByName != null) {
+ return;
+ }
+ Map<String, TableColumn> indexedColumns = new HashMap<>();
+ List<FieldSchema> fsList = new ArrayList<>(getColsInternal(false));
+ if (!hasNonNativePartitionSupport() || isView()) {
+ fsList.addAll(getPartitionKeys());
+ }
+ for (int i = 0; i < fsList.size(); i++) {
+ indexedColumns.put(fsList.get(i).getName().toLowerCase(), new
TableColumn(i, fsList.get(i)));
+ }
+ columnsByName = indexedColumns;
+ }
+
+ public Integer getColumnIndexByName(String colName) {
+ ensureColumnsIndexed();
+ TableColumn column = columnsByName.get(colName.toLowerCase());
+ return column != null ? column.index() : null;
+ }
+
+ public FieldSchema getColumnByName(String colName) {
+ ensureColumnsIndexed();
+ TableColumn column = columnsByName.get(colName.toLowerCase());
+ return column != null ? column.field() : null;
+ }
+
public List<FieldSchema> getCols() {
- return getColsInternal(false);
+ if (tableNonPartCols != null) {
+ return tableNonPartCols;
+ }
+ if (!hasNonNativePartitionSupport()) {
+ tableNonPartCols = getColsInternal(false);
+ } else {
+ List<FieldSchema> nonPartFields = new ArrayList<>();
+ Set<String> partFieldsName =
getPartCols().stream().map(FieldSchema::getName).collect(Collectors.toSet());
+ for (FieldSchema field : getColsInternal(false)) {
+ if (!partFieldsName.contains(field.getName())) {
+ nonPartFields.add(field);
+ }
+ }
+ tableNonPartCols = nonPartFields;
Review Comment:
.collect(Collectors.toList()); can be replaced with `.toList()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
