difin commented on code in PR #6539: URL: https://github.com/apache/hive/pull/6539#discussion_r3454260418
########## beeline/src/java/org/apache/hive/beeline/BeeLine.java: ########## @@ -121,25 +122,6 @@ import org.jline.terminal.Terminal; import org.jline.terminal.TerminalBuilder; -import static org.jline.builtins.Completers.FileNameCompleter; - - -/** - * A console SQL shell with command completion. - * <p> - * TODO: - * <ul> - * <li>User-friendly connection prompts</li> - * <li>Page results</li> - * <li>Handle binary data (blob fields)</li> - * <li>Implement command aliases</li> - * <li>Stored procedure execution</li> - * <li>Binding parameters to prepared statements</li> - * <li>Scripting language</li> - * <li>XA transactions</li> - * </ul> - * - */ Review Comment: Why should these TODO items be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
